Update tags_controller to use scopings on sectors and categories#1080
Merged
Update tags_controller to use scopings on sectors and categories#1080
Conversation
maebeale
reviewed
Feb 19, 2026
| def sectors | ||
| authorize! Sector, to: :tags_index? | ||
| @sectors = Sector.published.order(:name) | ||
| @sectors = Sector.published.has_taggings.order(:name) |
Collaborator
There was a problem hiding this comment.
@RJV333 this PR should include this scope being added to Sector, right?
Collaborator
Author
There was a problem hiding this comment.
I think that scope already exists actually. We just weren't using it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
The /tags endpoint should only feature button_links to tags that are being used (with at least one taggable) for the Sectors and Categories windows